Raise custom affix cap to 5 with tier-table line counts #2

Merged

denise merged 20 commits from feature/affix-cap-5-tier-table into illidari 2026-07-07 05:31:35 +00:00

Conversation 0 Commits 20 Files changed 30 +1870 -370

denise commented 2026-07-07 04:43:11 +00:00

Owner

Copy link

Summary

• Raise MaxAffixLines from 3 to 5 with loot-tier weighted line-count tables (AffixCountModel=tier_table)
• Instability Caches append new affix lines instead of replacing; cache tier tables for line count
• Add spell penetration (SPPEN) affix support and affix 68 SQL
• Fix Affix Artificer NPC spawn; disable broken slot-reroll gossip (placeholder until scrub item PR)
• Update docs and config defaults (Broadcast.MinAffixes=4, tier color thresholds)

Test plan

• Rebuild module and apply world SQL updates (2026_07_07_*)
• Reload random_enchants.conf; verify .affix config shows tier tables
• Kill mobs across T0–T5 and confirm 1–5 affix lines match tier weights
• Use Instability Cache on 1–4 line item; confirm append up to 5 lines
• Verify affix 68 (SPPEN) rolls and applies in combat
• Confirm Affix Artificer (900001) spawns; gossip shows placeholder only

## Summary - Raise MaxAffixLines from 3 to 5 with loot-tier weighted line-count tables (AffixCountModel=tier_table) - Instability Caches append new affix lines instead of replacing; cache tier tables for line count - Add spell penetration (SPPEN) affix support and affix 68 SQL - Fix Affix Artificer NPC spawn; disable broken slot-reroll gossip (placeholder until scrub item PR) - Update docs and config defaults (Broadcast.MinAffixes=4, tier color thresholds) ## Test plan - [ ] Rebuild module and apply world SQL updates (2026_07_07_*) - [ ] Reload random_enchants.conf; verify `.affix config` shows tier tables - [ ] Kill mobs across T0–T5 and confirm 1–5 affix lines match tier weights - [ ] Use Instability Cache on 1–4 line item; confirm append up to 5 lines - [ ] Verify affix 68 (SPPEN) rolls and applies in combat - [ ] Confirm Affix Artificer (900001) spawns; gossip shows placeholder only

denise added 20 commits 2026-07-07 04:43:11 +00:00

Merge pull request 'illidari' (#1) from illidari into master ... 4467434634

Reviewed-on: #1

fix(ci): stop rsync --delete from stripping tracked module files ... be6f974532

Co-authored-by: Cursor <cursoragent@cursor.com>

Implement server-side CMSG_INSPECT intercept to broadcast target's item affixes to the inspecting player 968e74f243

Fix AH affix display by injecting AuctionId into SuffixFactor 9f4b3ff338

Fix CanPacketSend loop misaligning SMSG_AUCTION_LIST_RESULT dcc6a36f03

Refactor AH affix delivery to use Addon Messages 84861f0717

Add client Spell.dbc patch tool for Instability Cache usability. ... 8f8a3c9b68

Enchant scroll items require spell EffectItemType to match the item entry; this script adds spells 901200-901202 to a 3.3.5a Spell.dbc.

Co-authored-by: Cursor <cursoragent@cursor.com>

Support HD clients: extract Spell.dbc from MPQ and install patch-enus-y.mpq. ... 25ec9a184c

WoW 3.3.5a installs keep Spell.dbc inside locale MPQs, not as a loose file; --wow-dir automates extract, patch, and MPQ packaging.

Co-authored-by: Cursor <cursoragent@cursor.com>

Fix Instability Cache target validation for enchant-scroll UX. ... 34f141a574

Clear bracer-only spell restrictions in the client patch, route imbues through SpellScript only, and accept any green+ weapon or armor instead of a random getEnchantTier roll.

Co-authored-by: Cursor <cursoragent@cursor.com>

Improve WoW path detection in client Spell.dbc patch tool. ... 24bc1dc493

Auto-detect installs under C:\games, normalize quoted paths, and list candidates when the given folder is missing or ambiguous.

Co-authored-by: Cursor <cursoragent@cursor.com>

Fix Instability Cache consuming extra items from each stack. ... d2bdcb85c1

Remove duplicate DestroyItemCount in SpellScript; item use already consumes one cache via spellcharges -1 in TakeCastItem.

Co-authored-by: Cursor <cursoragent@cursor.com>

Fix server-side pricing issues. 199e7c4640

fix(ci): git clean before reset so rsync cruft does not block deploy ... f96b08e38c

PR builds rsync into the live module tree without updating git. reset --hard
alone leaves untracked files that later block checkout on push deploys.

Co-authored-by: Cursor <cursoragent@cursor.com>

Tweak value distribution. b23f92793a

fix(ci): drop sudo bash git sync that hung waiting for password ... ed25c77842

forgejo-runner may only sudo deploy-modules.sh and rebuild.sh. The
pre-deploy bash -c git fetch step blocked indefinitely on sudo auth.
Use whitelisted sync-module-git.sh for PR restore; deploy-modules
already pulls with git clean -fd.

Co-authored-by: Cursor <cursoragent@cursor.com>

Raise affix price floors with ilvl scaling and rarity absolute minimums. ... 0fc6e1f33b

Epic affixes floor at 50g (Lesser Cache vendor parity); legendaries scale
to 200g+ at reference ilvl and hundreds of gold at endgame. Refund
Instability Caches when imbue fails and add tier fallback for empty pools.

Co-authored-by: Cursor <cursoragent@cursor.com>

fix(pricing): use linear ilvl scaling so endgame affixes are not capped ~150g ... f77a2b8b24

Exponent 1.55 at reference ilvl 80 heavily discounted ilvl 60–75 gear
(e.g. ilvl 63 legendary ≈ 136g). Default to linear ratio, ref ilvl 60,
300g legendary floor at reference.

Co-authored-by: Cursor <cursoragent@cursor.com>

Sync vanilla illidari zone tier seed with mod-illidari-difficulty distribution pass. ... 7e32e45c6f

Update blueprint section 8 and add world migration for 38 outdoor zones and 16 instances.

Co-authored-by: Cursor <cursoragent@cursor.com>

Remove duplicate illidari zone tier SQL that blocked worldserver startup. ... 6dfb78a231

Zone tier seed and migration live only in mod-illidari-difficulty; duplicate basenames caused AC auto-updater to abort before map load.

Co-authored-by: Cursor <cursoragent@cursor.com>

Raise custom affix cap to 5 with tier-table line counts. ... 7c6864b047

Replace the hardcoded three-line cascade with loot-tier weighted tables, append-mode Instability Caches, SPPEN support, and a fixed Affix Artificer NPC placeholder.

Co-authored-by: Cursor <cursoragent@cursor.com>

denise merged commit 7ff5ecf58c into illidari 2026-07-07 05:31:35 +00:00

denise referenced this pull request from a commit 2026-07-07 05:31:36 +00:00

Merge pull request 'Raise custom affix cap to 5 with tier-table line counts' (#2) from feature/affix-cap-5-tier-table into illidari

Commenting is not possible because the repository is archived.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

denise/mod-random-enchants!2

No description provided.